Fix use of serde #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
This was referenced Oct 10, 2025
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
esteve
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on ros2-rust/ros2_rust#532 there is a flaw in the way actions are generated: We use the template for messages twice side-by-side, and that template includes a
use serde::{...}declaration. That means a duplicate declaration will be put in, and the Rust compiler does not like this.This PR refactors the templates just slightly so that the message templates don't contain that declaration, and instead it exists in the outer template, exactly once in each spot where it belongs.