Fix use of serde #538
Merged
Fix use of serde #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
esteve
approved these changes
Oct 12, 2025
github-actions bot
pushed a commit
to knmcguire/ros2_rust
that referenced
this pull request
Oct 26, 2025
* Fix use of serde Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Apply cargo fmt without nightly Signed-off-by: Michael X. Grey <greyxmike@gmail.com> --------- Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
github-actions bot
pushed a commit
to knmcguire/ros2_rust
that referenced
this pull request
Oct 26, 2025
* Fix use of serde Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Apply cargo fmt without nightly Signed-off-by: Michael X. Grey <greyxmike@gmail.com> --------- Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
github-actions bot
pushed a commit
to knmcguire/ros2_rust
that referenced
this pull request
Oct 26, 2025
* Fix use of serde Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Apply cargo fmt without nightly Signed-off-by: Michael X. Grey <greyxmike@gmail.com> --------- Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
github-actions bot
pushed a commit
to knmcguire/ros2_rust
that referenced
this pull request
Oct 26, 2025
* Fix use of serde Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Apply cargo fmt without nightly Signed-off-by: Michael X. Grey <greyxmike@gmail.com> --------- Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
github-actions bot
pushed a commit
that referenced
this pull request
Oct 26, 2025
* Fix use of serde Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Apply cargo fmt without nightly Signed-off-by: Michael X. Grey <greyxmike@gmail.com> --------- Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
github-actions bot
pushed a commit
that referenced
this pull request
Oct 26, 2025
* Fix use of serde Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Apply cargo fmt without nightly Signed-off-by: Michael X. Grey <greyxmike@gmail.com> --------- Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #532, this PR updates the vendored action bindings based on ros2-rust/rosidl_rust#9
This PR also includes the serde feature in the CI tests to make sure we don't overlook this in the future.
There are also some unrelated formatting changes that came from running
cargo +nightly fmt.