Update showimage.cpp removing extra std::cerr outputs#785
Open
jmackay2 wants to merge 1 commit intoros2:rollingfrom
Open
Update showimage.cpp removing extra std::cerr outputs#785jmackay2 wants to merge 1 commit intoros2:rollingfrom
jmackay2 wants to merge 1 commit intoros2:rollingfrom
Conversation
Signed-off-by: jmackay2 <1.732mackay@gmail.com>
ahcorde
approved these changes
May 1, 2026
ahcorde
requested changes
May 1, 2026
Contributor
ahcorde
left a comment
There was a problem hiding this comment.
can you retarget to rolling? then we can backport this to other distros
fujitatomoya
reviewed
May 1, 2026
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
fix looks good to me. and probably we can backport this to downstream distros.
Contributor
Author
Thanks for pointing this out. Done. |
Collaborator
|
Pulls: #785 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Right now when running this you get the following:
The
std::cerrmessage is redundant and doesn't actually display any additional helpful information. I propose we remove it since it doesn't seem to serve a purpose.Is this user-facing behavior change?
This just changes the terminal output when running
showImage.Did you use Generative AI?
No.