Skip to content

Update showimage.cpp removing extra std::cerr outputs#785

Open
jmackay2 wants to merge 1 commit intoros2:rollingfrom
jmackay2:patch-2
Open

Update showimage.cpp removing extra std::cerr outputs#785
jmackay2 wants to merge 1 commit intoros2:rollingfrom
jmackay2:patch-2

Conversation

@jmackay2
Copy link
Copy Markdown
Contributor

@jmackay2 jmackay2 commented May 1, 2026

Description

Right now when running this you get the following:

/# ros2 run image_tools showimage 
[INFO] [1777605547.094321809] [showimage]: Subscribing to topic 'image'
[INFO] [1777605547.203184824] [showimage]: Received image #camera_frame
Received image #camera_frame
[INFO] [1777605547.533933569] [showimage]: Received image #camera_frame
Received image #camera_frame
[INFO] [1777605547.538867302] [showimage]: Received image #camera_frame
Received image #camera_frame
[INFO] [1777605547.543719581] [showimage]: Received image #camera_frame
Received image #camera_frame
[INFO] [1777605547.548553095] [showimage]: Received image #camera_frame
Received image #camera_frame
[INFO] [1777605547.553280199] [showimage]: Received image #camera_frame
Received image #camera_frame

The std::cerr message is redundant and doesn't actually display any additional helpful information. I propose we remove it since it doesn't seem to serve a purpose.

Is this user-facing behavior change?

This just changes the terminal output when running showImage.

Did you use Generative AI?

No.

Signed-off-by: jmackay2 <1.732mackay@gmail.com>
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you retarget to rolling? then we can backport this to other distros

Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix looks good to me. and probably we can backport this to downstream distros.

@jmackay2 jmackay2 changed the base branch from lyrical to rolling May 1, 2026 13:59
@jmackay2
Copy link
Copy Markdown
Contributor Author

jmackay2 commented May 1, 2026

can you retarget to rolling? then we can backport this to other distros

Thanks for pointing this out. Done.

@fujitatomoya
Copy link
Copy Markdown
Collaborator

Pulls: #785
Gist: https://gist.githubusercontent.com/fujitatomoya/15c287a66258db9f4b3852d33906b0ee/raw/ff7ff333ed1c3104fff788c70a0b5fe86463aef6/ros2.repos
BUILD args: --packages-up-to image_tools
TEST args: --packages-select image_tools
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19105

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants