MARA Threat Model #228

olaldiko · 2019-04-08T09:13:32Z

This adds an extension to the original Threat Model proposed by @thomas-moulard started on #218 .

Based on the work done by the Amazon Robotics team, we have developed a threat model for an industrial cobot, the MARA by Acutronics Robotics.

We also have some additions on attack vectors and assets in the main threat table.

The objective of this threat model extension is to create a replicable base for creating threat models for different robots on industrial environments.

Work done by @o-olalde, @XabierPB and @borkenerice and myself (@olaldiko) as part of Alias Robotics.

vmayoral · 2019-04-08T14:03:16Z

Maybe it's worth sharing that Acutronic Robotics has been funding this work for the last few months and encouraged a release aligned with @thomas-moulard's (and the rest of his colleagues).

I will go through the PR ~~tonight~~ soon and will try contributing with what's been our experience from "the other side". @LanderU and @ahcorde, feel free to jump in and add your views as well.

thomas-moulard · 2019-04-08T15:55:08Z

Awesome! 👍 I'll start reviewing this but before that, would you mind making sure that the new files are passing the Markdown linter: mdl.

gem install --user-install mdl / mdl ./myfile.md

I had to ignore the MD033 forbidding inline HTML but everything else seems like things which can be fixed.

olaldiko · 2019-04-08T16:30:36Z

Thanks @thomas-moulard! Sure, we'll get on it ASAP!

thomas-moulard · 2019-04-08T16:55:05Z

articles/ros2_threat_model.md

@@ -45,19 +52,78 @@ th {

 </div>

+## Table of Contents
+
+- [{{ page.title }}](#pagetitle)


The toc should appear automatically with that tag when running it with jekyll?

I realized that I had this tag and it's not doing what I expect it to do. I guess it's fine to keep that manual for this PR but we should probably try to automate this somehow.

We found out that putting a "* TOC" just above {:toc} generates a visible table of contents. See example below. You could just try! Visually it generates the toc on the right side of the page (using Jekyll)

Suggested change

- [{{ page.title }}](#pagetitle)

* TOC

{:toc}

- [{{ page.title }}](#pagetitle)

@olaldiko will you accept this? If so, maybe we should remove the TOC generated manually below?

thomas-moulard · 2019-04-08T16:57:19Z

articles/ros2_threat_model.md

@@ -186,6 +252,10 @@ attack).
    <td>Physical Safety</td>
    <td>The robotic system must not harm its users or environment.</td>
  </tr>
+  <tr>
+    <td>Robot Integrity</td>
+    <td>The robotic system must not damage itself.</td>


I don't have a strong opinion there, but compared to expanding the scope of Physical Safety, do you see cases where those two columns values won't be identical?

articles/ros2_threat_model.md

thomas-moulard · 2019-04-08T18:35:45Z

articles/ros2_threat_model.md

+
+[Diagram Source (draw.io)](ros2_threat_model/attack_tree_physical.xml)
+
+The next diagram shows the infrastructure affected on a possible attack based on a compromise of a physical communication port.


affected by?

To me it sounds better "the affected infrastructure". Opinions?

articles/ros2_threat_model.md

thomas-moulard · 2019-04-08T18:38:39Z

@olaldiko this is great, thanks for sending this! Do you think we should align and use RVSS for all of the doc instead of DREAD?

@thomas-moulard

Good catch from @thomas-moulard! I don't think it needs further discussion ;)

Just reorder references alphabetically.

Update reference order

Correct "atempt" typo

Typos: Just correct Maximun and Minimun

Correct maximun/minimun

olaldiko · 2019-04-09T08:53:54Z

@olaldiko this is great, thanks for sending this! Do you think we should align and use RVSS for all of the doc instead of DREAD?

While it would be nice, in this case RVSS is not meant for measuring risks, but actual vulnerabilities. It would be the equivalent of the CVSS for robotics.
However, I think that it would be interesting to evaluate each of the robots with the RSF as well to define weak points and improvements. What do you think, @thomas-moulard?

Just reorder references alphabetically.

Add linter fixes

articles/ros2_threat_model.md

Fix link spacing

thomas-moulard · 2019-04-09T17:47:12Z

@olaldiko That SGTM, not sure if we will be able to follow-up on that for TB3 right now but it seems better to have only on standard and make it evolve as/if needed. We can explain that in another section "How to add your robot to this threat model? You should evaluate your threats using RSF, etc.". If you would like to add this section in this PR that'd be great, otherwise it can done later by either you or us.

olaldiko · 2019-04-10T13:41:05Z

Sure @thomas-moulard, that SGTM too. I will start working on the new section!

Update with add robot section

…l_pull

thomas-moulard

SGTM, thanks! We can merge this and iterate on the doc as needed IMHO.

articles/ros2_threat_model.md

thomas-moulard · 2019-04-16T21:34:32Z

@olaldiko Let's rebase this and we can merge the doc 🚢

…l_pull

olaldiko · 2019-04-17T08:48:08Z

Good! @thomas-moulard, @tfoote, what would be the procedure here? Shall we rewrite history on the PR itself or the rebase is performed when merging into gh-pages branch?

articles/ros2_threat_model.md

Co-Authored-By: olaldiko <gorka.olalde@gmail.com>

thomas-moulard · 2019-04-17T23:50:43Z

I'll let @tfoote answer this one. I did rebase and pushed with git push --force-with-lease but I know not everyone agrees this is the "right thing to do".

vmayoral · 2019-04-26T11:41:32Z

@tfoote and @thomas-moulard can we merge this please?

We are preparing a few additional contributions that should ship soon after this one.

vmayoral · 2019-04-26T11:42:05Z

@olaldiko are you guys fine with it?

olaldiko · 2019-04-26T11:44:11Z

Sure! All clear from our side! El vie., 26 abr. 2019 13:42, Víctor Mayoral Vilches < notifications@github.com> escribió:

…

@olaldiko <https://github.com/olaldiko> are you guys fine with it? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#228 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANBZKDXXMXAHN6TA6H6F63PSLTBDANCNFSM4HEGXKIQ> .

thomas-moulard · 2019-04-26T17:13:01Z

@olaldiko Can you rebase the doc? I will merge it once it's done.

vmayoral · 2019-04-26T18:00:42Z

Thanks a lot for reacting @thomas-moulard, great!

@olaldiko, happy let me know if you need help rebasing the file.

…l_pull

Co-Authored-By: olaldiko <gorka.olalde@gmail.com>

…ics/design into mara_threatmodel_pull

olaldiko · 2019-04-30T09:32:22Z

@thomas-moulard, I think that we have successfully rebased the commits now. Please, check and let me know if any changes need to be done!

thomas-moulard · 2019-04-30T17:11:35Z

@olaldiko Could you check again? I can't merge because there are still conflicts in this PR:

Rebasing the commits of this branch on top of the base branch cannot be performed automatically due to conflicts encountered while reapplying the individual commits from the head branch.

olaldiko · 2019-05-01T11:56:01Z

@thomas-moulard , I have been doing several tests on my own fork, and I think that the best strategy here would be to squash and merge into the base branch instead of rebasing. This way the changes will show up as a single commit on the gh-pages branch. I think that this was done in #218 and others as well, as each PR shows up as a single commit on base. No conflicts arise following this strategy. Could you please check and tell me your thoughts?
Thanks!

dirk-thomas · 2019-05-22T22:33:55Z

@thomas-moulard This document doesn't follow the style guide for markdown (https://index.ros.org/doc/ros2/Contributing/Developer-Guide/#markdown-restructured-text-docblocks). Please update the doc to follow the one-sentence-per-line rule. See https://github.com/ros2/design/pull/236/files#diff-60aa2b3022e7728b236f31c650141eceL3544 for a case why the current state is not desired.

thomas-moulard · 2019-05-23T05:15:12Z

Thanks Dirk for checking, I assigned to myself #237 and I'll do that by EOW.

thomas-moulard · 2019-05-24T23:56:49Z

#238 should fix style issues.

Mara Threat Model. Initial Version

de89353

tfoote added the in review Waiting for review (Kanban column) label Apr 8, 2019

olaldiko changed the title ~~Mara Threat Model. Initial Version~~ MARA Threat Model Apr 8, 2019

Update vulnerability pie image to include title

b3bbaa3

thomas-moulard reviewed Apr 8, 2019

View reviewed changes

XabierPB and others added 7 commits April 8, 2019 21:34

Correct "atempt" typo

8cd0874

Good catch from @thomas-moulard! I don't think it needs further discussion ;)

Update reference order

916c2e6

Just reorder references alphabetically.

Merge pull request #2 from XabierPB/patch-2

436231f

Update reference order

Merge pull request #1 from XabierPB/patch-1

f8c6550

Correct "atempt" typo

Correct maximun/minimun

2a68d83

Typos: Just correct Maximun and Minimun

Merge pull request #3 from aliasrobotics/correct_max_min_m-1

1e422e3

Correct maximun/minimun

Add linter fixes

247c050

XabierPB added 2 commits April 9, 2019 10:56

Update reference order

b20104d

Just reorder references alphabetically.

Merge pull request #4 from aliasrobotics/linter_review

be16ec3

Add linter fixes

LanderU reviewed Apr 9, 2019

View reviewed changes

articles/ros2_threat_model.md Outdated Show resolved Hide resolved

olaldiko and others added 2 commits April 9, 2019 11:05

Fix link spacing

1e600b5

Merge pull request #5 from aliasrobotics/fix_links

9fe14ac

Fix link spacing

olaldiko added 2 commits April 10, 2019 15:21

Merge with upstream

1b0d02e

Merge branch 'ros2-gh-pages' into mara_threatmodel_pull

0b037dd

olaldiko and others added 3 commits April 15, 2019 10:37

Update with add robot section

aaf97ce

Merge pull request #7 from aliasrobotics/add_your_robot_section

27fe419

Update with add robot section

Merge remote-tracking branch 'upstream/gh-pages' into mara_threatmode…

8962a44

…l_pull

thomas-moulard approved these changes Apr 15, 2019

View reviewed changes

articles/ros2_threat_model.md Outdated Show resolved Hide resolved

Fix typo on robot addition steps

7072977

XabierPB approved these changes Apr 16, 2019

View reviewed changes

borkenerice approved these changes Apr 16, 2019

View reviewed changes

LanderU approved these changes Apr 16, 2019

View reviewed changes

Merge remote-tracking branch 'upstream/gh-pages' into mara_threatmode…

e82ca87

…l_pull

vmayoral reviewed Apr 17, 2019

View reviewed changes

articles/ros2_threat_model.md Show resolved Hide resolved

vmayoral reviewed Apr 17, 2019

View reviewed changes

articles/ros2_threat_model.md Outdated Show resolved Hide resolved

Update articles/ros2_threat_model.md

9d19c06

Co-Authored-By: olaldiko <gorka.olalde@gmail.com>

olaldiko and others added 4 commits April 30, 2019 11:25

Merge remote-tracking branch 'upstream/gh-pages' into mara_threatmode…

c35d0af

…l_pull

Update articles/ros2_threat_model.md

e8b777e

Co-Authored-By: olaldiko <gorka.olalde@gmail.com>

Merge branch 'mara_threatmodel_pull' of https://github.com/aliasrobot…

32fdf5d

…ics/design into mara_threatmodel_pull

Remove repeated references

deac6cf

thomas-moulard merged commit 4d127ad into ros2:gh-pages May 1, 2019

tfoote removed the in review Waiting for review (Kanban column) label May 1, 2019

thomas-moulard mentioned this pull request May 23, 2019

Fix ROS 2 threat model style errors #237

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MARA Threat Model #228

MARA Threat Model #228

olaldiko commented Apr 8, 2019

vmayoral commented Apr 8, 2019 •

edited

Loading

thomas-moulard commented Apr 8, 2019

olaldiko commented Apr 8, 2019

thomas-moulard Apr 8, 2019

borkenerice Apr 9, 2019

thomas-moulard Apr 9, 2019 •

edited

Loading

XabierPB Apr 9, 2019 •

edited

Loading

vmayoral Apr 17, 2019

thomas-moulard Apr 8, 2019

vmayoral Apr 17, 2019

thomas-moulard Apr 8, 2019

XabierPB Apr 8, 2019

thomas-moulard Apr 15, 2019

thomas-moulard commented Apr 8, 2019

olaldiko commented Apr 9, 2019

thomas-moulard commented Apr 9, 2019

olaldiko commented Apr 10, 2019

thomas-moulard left a comment

thomas-moulard commented Apr 16, 2019

olaldiko commented Apr 17, 2019

thomas-moulard commented Apr 17, 2019

vmayoral commented Apr 26, 2019

vmayoral commented Apr 26, 2019

olaldiko commented Apr 26, 2019 via email

thomas-moulard commented Apr 26, 2019

vmayoral commented Apr 26, 2019 •

edited

Loading

olaldiko commented Apr 30, 2019

thomas-moulard commented Apr 30, 2019 •

edited

Loading

olaldiko commented May 1, 2019

dirk-thomas commented May 22, 2019

thomas-moulard commented May 23, 2019

thomas-moulard commented May 24, 2019


		[Diagram Source (draw.io)](ros2_threat_model/attack_tree_physical.xml)

		The next diagram shows the infrastructure affected on a possible attack based on a compromise of a physical communication port.

MARA Threat Model #228

MARA Threat Model #228

Conversation

olaldiko commented Apr 8, 2019

vmayoral commented Apr 8, 2019 • edited Loading

thomas-moulard commented Apr 8, 2019

olaldiko commented Apr 8, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thomas-moulard Apr 9, 2019 • edited Loading

Choose a reason for hiding this comment

XabierPB Apr 9, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thomas-moulard commented Apr 8, 2019

olaldiko commented Apr 9, 2019

thomas-moulard commented Apr 9, 2019

olaldiko commented Apr 10, 2019

thomas-moulard left a comment

Choose a reason for hiding this comment

thomas-moulard commented Apr 16, 2019

olaldiko commented Apr 17, 2019

thomas-moulard commented Apr 17, 2019

vmayoral commented Apr 26, 2019

vmayoral commented Apr 26, 2019

olaldiko commented Apr 26, 2019 via email

thomas-moulard commented Apr 26, 2019

vmayoral commented Apr 26, 2019 • edited Loading

olaldiko commented Apr 30, 2019

thomas-moulard commented Apr 30, 2019 • edited Loading

olaldiko commented May 1, 2019

dirk-thomas commented May 22, 2019

thomas-moulard commented May 23, 2019

thomas-moulard commented May 24, 2019

vmayoral commented Apr 8, 2019 •

edited

Loading

thomas-moulard Apr 9, 2019 •

edited

Loading

XabierPB Apr 9, 2019 •

edited

Loading

vmayoral commented Apr 26, 2019 •

edited

Loading

thomas-moulard commented Apr 30, 2019 •

edited

Loading