Extend eigen-accel conversions (backport #887)#891
Merged
Conversation
(cherry picked from commit 9380c65)
ahcorde
approved these changes
Jan 8, 2026
Contributor
|
Pulls: #891 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As promised in my previous PR, I have extended the conversions by introducing the
toMsgfor converting an Eigen matrix to an Accel message. I kept the function signature similar to othertoMsgones that have ambiguity with other types (e.g., Vector3d and Point or Vector3 and Point32).Furthuremore, I added some tests for both
fromMsgas well astoMsgfunctions of eigen-accel conversions.The only thing that I am a bit doubting is why in docstrings of such
toMsgfunctions it is always said:This function is a specialization of the toMsg template defined in tf2/convert.h.I could not find any
toMsgtemplate with such function signature i.e., two inputs. There's only this:Am I missing something? In any case, I have kept the docstring the same also here.
This is an automatic backport of pull request #887 done by Mergify.