Skip to content

Extend eigen-accel conversions (backport #887)#892

Merged
ahcorde merged 1 commit intohumblefrom
mergify/bp/humble/pr-887
Jan 8, 2026
Merged

Extend eigen-accel conversions (backport #887)#892
ahcorde merged 1 commit intohumblefrom
mergify/bp/humble/pr-887

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Jan 8, 2026

As promised in my previous PR, I have extended the conversions by introducing the toMsg for converting an Eigen matrix to an Accel message. I kept the function signature similar to other toMsg ones that have ambiguity with other types (e.g., Vector3d and Point or Vector3 and Point32).

Furthuremore, I added some tests for both fromMsg as well as toMsg functions of eigen-accel conversions.

The only thing that I am a bit doubting is why in docstrings of such toMsg functions it is always said:
This function is a specialization of the toMsg template defined in tf2/convert.h.
I could not find any toMsg template with such function signature i.e., two inputs. There's only this:

template<typename A, typename B>
B toMsg(const A & a);

Am I missing something? In any case, I have kept the docstring the same also here.


This is an automatic backport of pull request #887 done by Mergify.

@mergify mergify bot mentioned this pull request Jan 8, 2026
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Jan 8, 2026

Pulls: #892
Gist: https://gist.githubusercontent.com/ahcorde/f8cc0f2edae7abea7ea02787b8ebffad/raw/da6a7751a00f9d5eaca29a0d1180fa2239b629b7/ros2.repos
BUILD args: --packages-above-and-dependencies tf2_eigen test_tf2
TEST args: --packages-above tf2_eigen test_tf2
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17884

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 13db646 into humble Jan 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants