Skip to content

Fix function params indentation #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

Fix function params indentation #833

merged 1 commit into from
Mar 10, 2025

Conversation

@christophebedard
Copy link
Member

@christophebedard christophebedard commented Mar 9, 2025

This is what I could find with a quick search, but there might be more.

@christophebedard
Fix function params indentation
537733b 
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
fujitatomoya
fujitatomoya approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

just curious, this kind of mis-indent can be checked by some static analyzer like linter?

@fujitatomoya
Copy link
Contributor

fujitatomoya commented Mar 10, 2025

Pulls: #833
Gist: https://gist.githubusercontent.com/fujitatomoya/b06f67d249523ab9ea384bbc1ef4cedd/raw/7e6583c7cb2c6f88cb980cc07d2d634a0ce339f7/ros2.repos
BUILD args: --packages-above-and-dependencies launch launch_testing
TEST args: --packages-above launch launch_testing
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15314

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 151b024 into rolling Mar 10, 2025
3 checks passed
@ahcorde
Copy link
Contributor

ahcorde commented Mar 10, 2025

https://github.com/Mergifyio backport jazzy

@mergify
Copy link

mergify bot commented Mar 10, 2025 •
edited
Loading

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 10, 2025
@christophebedard @mergify
Fix function params indentation (#833)
90a8213 
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
(cherry picked from commit 151b024)
@mergify mergify bot mentioned this pull request Mar 10, 2025
Merged
@christophebedard christophebedard deleted the christophebedard/fix-indentation branch March 10, 2025 16:23
@christophebedard
Copy link
Member Author

christophebedard commented Mar 10, 2025

just curious, this kind of mis-indent can be checked by some static analyzer like linter?

Ideally yes, but I noticed this before and my conclusion was that it's somehow (1) not caught by linters and (2) still working even though indentation is important in Python.

ahcorde added a commit that referenced this pull request Mar 10, 2025
@ahcorde
Merge pull request #834 from ros2/mergify/bp/jazzy/pr-833
1a3f03a 
Fix function params indentation (backport #833)
@christophebedard
Copy link
Member Author

christophebedard commented Apr 11, 2025

just curious, this kind of mis-indent can be checked by some static analyzer like linter?

Ideally yes, but I noticed this before and my conclusion was that it's somehow (1) not caught by linters and (2) still working even though indentation is important in Python.

Turns out that this is totally allowed by PEP 8, see https://peps.python.org/pep-0008/#indentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@christophebedard @fujitatomoya @ahcorde