Fixed flaky test busy waiting test#3155
Merged
Merged
Conversation
jmachowinski
changed the title
Collaborator
Author
|
Pulls: #3155
|
Signed-off-by: Janosch Machowinski <j.machowinski@cellumation.com>
jmachowinski
force-pushed
the
jm/fix_test_busy_waiting
branch
from
14d5854 to
8c9e54d
Compare
Collaborator
Author
|
Note, I pushed the wrong branch initially and started the CI before the correction push. |
mjcarroll
approved these changes
May 29, 2026
mjcarroll
left a comment
mjcarroll
left a comment
Member
There was a problem hiding this comment.
Minor nits on the comments, but otherwise LGTM with green CI!
Co-authored-by: Michael Carroll <mjcarroll.oss@gmail.com> Signed-off-by: Janosch Machowinski <jmachowinski@users.noreply.github.com>
skyegalaxy
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed data race in flaky test.
Fixes # (issue)
#3154
Is this user-facing behavior change?
Did you use Generative AI?
No