Skip to content

Add ConstRefCallback in use_take_shared_method#3066

Open
mini-1235 wants to merge 2 commits intoros2:rollingfrom
mini-1235:fix/intraprocess
Open

Add ConstRefCallback in use_take_shared_method#3066
mini-1235 wants to merge 2 commits intoros2:rollingfrom
mini-1235:fix/intraprocess

Conversation

@mini-1235
Copy link
Contributor

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI.

while the naming is a bit misleading, "take shared" is appropriate for any callback that doesn't require exclusive ownership, i think. and that includes both shared-pointer callbacks and const-reference callbacks.

@fujitatomoya
Copy link
Collaborator

Pulls: #3066
Gist: https://gist.githubusercontent.com/fujitatomoya/967ec7dafb600506a0323b361c3f62bd/raw/35435ee094cc258fe3d1f204984da08f494371ab/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18212

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@mini-1235
Copy link
Contributor Author

Let me try to rebase and see if it fixes the build failure

@mini-1235
Copy link
Contributor Author

mini-1235 commented Feb 17, 2026

15:19:18 99: 
15:19:18 99: [  FAILED  ] TestBusyWaiting/EventsExecutor.test_spin, where TypeParam = rclcpp::experimental::executors::EventsExecutor (10011 ms)
15:19:18 99: [----------] 3 tests from TestBusyWaiting/EventsExecutor (10029 ms total)
15:19:18 99: 
15:19:18 99: [----------] Global test environment tear-down
15:19:18 99: [==========] 9 tests from 3 test suites ran. (10123 ms total)
15:19:18 99: [  PASSED  ] 8 tests.
15:19:18 99: [  FAILED  ] 1 test, listed below:
15:19:18 99: [  FAILED  ] TestBusyWaiting/EventsExecutor.test_spin, where TypeParam = rclcpp::experimental::executors::EventsExecutor
15:19:18 99: 
15:19:18 99:  1 FAILED TEST
15:19:18 99: -- run_test.py: return code 1
15:19:18 99: -- run_test.py: inject classname prefix into gtest result file '/tmp/ws/test_results/rclcpp/test_executors_busy_waiting.gtest.xml'
15:19:18 99: -- run_test.py: verify result file '/tmp/ws/test_results/rclcpp/test_executors_busy_waiting.gtest.xml'
15:19:18  99/122 Test  #99: test_executors_busy_waiting ..............................***Failed   10.35 sec

I don't think this is related to this PR, right?

@fujitatomoya
Copy link
Collaborator

Yup, let me re-run the CI.

@fujitatomoya
Copy link
Collaborator

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments