Skip to content

Comments

Revert "improve lookup time for matches_any_publishers(). (#3068)"#3077

Merged
ahcorde merged 1 commit intorollingfrom
revert-issues/3067
Feb 20, 2026
Merged

Revert "improve lookup time for matches_any_publishers(). (#3068)"#3077
ahcorde merged 1 commit intorollingfrom
revert-issues/3067

Conversation

@fujitatomoya
Copy link
Collaborator

@fujitatomoya fujitatomoya commented Feb 20, 2026

This reverts commit b6730f9.

it looks like this generates the regression #3068 (comment).
although we are not sure what the root cause is, i suggest to revert the fix (performance improvement) to avoid breaking the userspace.

Description

Revert #3068

Is this user-facing behavior change?

Did you use Generative AI?

Additional Information

This reverts commit b6730f9.

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

Pulls: #3077
Gist: https://gist.githubusercontent.com/fujitatomoya/92e7e30a2a63d5611394cbe1ad55336b/raw/33d39c10c3932bcb522cd234c7f87568d3722a02/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18273

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmachowinski can you approve this?

i do not want this to be released with next rolling sync, which is planning in next week.

@ahcorde ahcorde merged commit 1bf4e6a into rolling Feb 20, 2026
3 checks passed
@ahcorde ahcorde deleted the revert-issues/3067 branch February 20, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants