Skip to content

Remove comment about removed StaticSingleThreadedExecutor#3121

Merged
ahcorde merged 1 commit intoros2:rollingfrom
mini-1235:fix/remove-comments
Apr 1, 2026
Merged

Remove comment about removed StaticSingleThreadedExecutor#3121
ahcorde merged 1 commit intoros2:rollingfrom
mini-1235:fix/remove-comments

Conversation

@mini-1235
Copy link
Copy Markdown
Contributor

Description

Closes #2462

Is this user-facing behavior change?

No, this is only removing comments after static single threaded executor is removed

Did you use Generative AI?

Additional Information

Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 good eye 👁️ thanks!

@fujitatomoya
Copy link
Copy Markdown
Collaborator

Pulls: #3121
Gist: https://gist.githubusercontent.com/fujitatomoya/f69254174dedcaa88b792bfb9e4f115b/raw/be9e8e948d079d9647f8d0ca767021d17562b326/ros2.repos
BUILD args: --packages-up-to rclcpp
TEST args: --packages-select rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18779

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit efd870f into ros2:rolling Apr 1, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

max_duration not respected in spin_some for StaticSingleThreadedExecutor and EventsExecutor

3 participants