chore: remove outdated TODO in GenericClient#3146
Conversation
…icClient Signed-off-by: Pietro Gelmini <86184562+Gelminaio@users.noreply.github.com>
|
The TODO is just plain wrong. We should not use the C allocator here. |
|
Also, are you sure you did not use AI ? |
|
Yeah, you got me 😅. To be completely honest, I used Gemini to help me with the exact syntax for the allocator, since I'm still getting used to the ROS 2 memory management internals. I didn't check the AI box because I thought it was meant for fully written by AI, not just snippets. Completely my bad! Good to know that the TODO is just outdated. I'll close this PR right away. Sorry for the noise! |
|
You can modify the PR to remove the todo though... |
Removed custom allocator for request header and used new allocation method. Signed-off-by: Pietro Gelmini <86184562+Gelminaio@users.noreply.github.com>
Gelminaio
changed the title
|
Removed the TODO and kept the original code as suggested. Thanks for the catch! @jmachowinski |
|
Merging without CI, as only comments were modified. |
I think the process is to skip ci.ros2.org when comments are modified, but we do still want to have a green *pr job (e.g., Rpr for Rolling) in case a linters complain, e.g., line length. In this case, *pr jobs are disabled, so a simple (maybe Linux-only) ci.ros2.org would've been good. |
3 participants
Description
Removed an incorrect TODO comment
Is this user-facing behavior change?
No
Did you use Generative AI?
No
Additional Information