Call rclcpp::shutdown() in the component containers#3158
Merged
ahcorde merged 1 commit intoJun 2, 2026
Conversation
Signed-off-by: Hugo Laloge <hugo.laloge@gmail.com>
Hugal31
force-pushed
the
fix/call-shutdown-in-components-containers
branch
from
1d211c2 to
0e5f46a
Compare
ahcorde
approved these changes
Jun 1, 2026
Contributor
|
Pulls: #3158
|
fujitatomoya
approved these changes
Jun 2, 2026
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with green CI.
Collaborator
|
@Mergifyio backport lyrical |
Contributor
✅ Backports have been createdDetails
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ROS2 executables should call rclcpp::shutdown before exiting to avoid issues with some RMW, namely Zenoh. Explicitly call it in the component containers.
Is this user-facing behavior change?
No.
Did you use Generative AI?
No.