Add Callback Group Events Executor (Kilted Backport)#3164
Open
skyegalaxy wants to merge 5 commits into
Open
Conversation
added 5 commits
June 5, 2026 10:45
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
jmachowinski
approved these changes
Jun 5, 2026
Member
Author
|
Pulls: #3164 |
Member
Author
|
rhel CI failures are unrelated and known. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the Callback Group Events Executor introduced in #3097 to rclcpp mainline for Kilted. Also updates the executor tests with the new executor.
The following compatibility changes were needed:
get_clocktoTimerBase. Ought to be an additive, non-virtual function which should not break ABI.add_node,remove_node,add_callback_group,remove_callback_group) to pass by value (it was changed for lyrical in perf: Optimized out shared_ptr copies #3079)component_container_events_cbgexecutable which works similarly to theexisting component_container_mtexec, allowing the passing ofthread_numvia ROS paramIs this user-facing behavior change?
Users will now be able to use the Callback Group Events Executor on Kilted.
Users will be able to use component containers with the Callback Group Events Executor on Kilted with the addition of
component_container_events_cbg.Did you use Generative AI?
Claude Opus 4.8 was used to cherry-pick the commits from #3163, applying only the ones that apply to kilted.
Additional Information