Do not export dl in rcutils_LIBRARIES (backport #522) #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai> (cherry picked from commit 306fcfa)
|
Backporting the fix to the warning, as it's happening on Kilted also |
ahcorde
approved these changes
Oct 22, 2025
Contributor
|
Pulls: #524
|
sloretz
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #521
Is this user-facing behavior change?
If someone still uses old-style CMake variables, then the list in
rcutils_LIBRARIESno longer includesdl.Did you use Generative AI?
no
Additional Information
Maybe it's time to drop old-style CMake variables altogether? We've supported modern CMake targets for a long time now.
This is an automatic backport of pull request #522 done by [Mergify](https://mergify.com).