Update launch test for change related to enviroment variables in launch#354
Merged
jacobperron merged 1 commit intomasterfrom Mar 28, 2022
Merged
Update launch test for change related to enviroment variables in launch#354jacobperron merged 1 commit intomasterfrom
jacobperron merged 1 commit intomasterfrom
Conversation
Since ros2/launch#601, launch no longer modifies os.environ. Rather, it updates a dictionary owned by the launch context, which is then passed to launched executables. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Member
Author
|
Note, with the latest commit in ros2/launch#601, this PR is not technically necessary anymore. |
fujitatomoya
approved these changes
Mar 4, 2022
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
ros2/launch@3d2a695 reads the data from os.environ but i think this is nicer to have.
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since ros2/launch#601, launch no longer modifies os.environ.
Rather, it updates a dictionary owned by the launch context, which is then passed to
launched executables.
Connects to ros2/launch#601