Conversation
Contributor
|
@ros-pull-request-builder retest this please |
clalancette
reviewed
Aug 30, 2022
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
I've left a few things to think about.
Contributor
|
(also, uncrustify is unhappy) |
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
wjwwood
force-pushed
the
nonnull_macros
branch
from
ed57351 to
328245b
Compare
Signed-off-by: William Woodall <william@osrfoundation.org>
Member
Author
|
CI:
@clalancette if you have time to just have glance and comment on the one open thread, that would be good, but I think this is good to go? |
clalancette
approved these changes
Oct 12, 2022
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Looks good with green CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this useful when implementing a helper header for the new
<memory_resource>header in c++17, because some implementations are incomplete so I had to implement a few functions it helped to mark some parameters and return types as non-null for the compiler.I will link that pr (for the helper header) here when I have it up.