Restrict overmatching MACH ifdef to only trigger on OSX and Mach#386
Merged
clalancette merged 1 commit intoros2:rollingfrom Sep 23, 2022
Zopolis4:rolling
Merged
Restrict overmatching MACH ifdef to only trigger on OSX and Mach#386clalancette merged 1 commit intoros2:rollingfrom Zopolis4:rolling
clalancette merged 1 commit intoros2:rollingfrom
Zopolis4:rolling
Conversation
clalancette
requested changes
Sep 21, 2022
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
One fix inline, then this will be ready for CI.
Signed-off-by: Zopolis4 <creatorsmithmdt@gmail.com>
clalancette
approved these changes
Sep 22, 2022
Contributor
|
CI:
|
Contributor
Author
|
This doesn't touch windows at all, so not sure what's going on there. |
Contributor
We've been having some instability with the Windows workers, it looks like we ran into it. I've kicked off a new job. |
Contributor
|
The single failing test on Windows has nothing to do with this, so I'll go ahead and merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As said on line 43, this check is only intended for OSX.
Hurd uses a different version of Mach that does not have
mach/clock.h.https://www.gnu.org/software/hurd/hurd/porting/guidelines.html
Signed-off-by: Maximilian Downey Twiss creatorsmithmdt@gmail.com