Cleanup time_unix.c#389
Merged
clalancette merged 1 commit intorollingfrom Oct 1, 2022
Merged
Conversation
The file was pretty messy. Cleanups:
1. Remove totally unnecessary #ifdef __cplusplus; that is
only necessary in headers.
2. Remove unnecessary include to ./common.h.
3. Change WOULD_BE_NEGATIVE to an inline function, which will
at least give us some type checking.
4. Get rid of unnecessary duplicated code for macOS. Most of
the time the code was exactly the same.
5. Make sure to check the return value from clock_gettime.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Contributor
Author
|
CI:
|
fujitatomoya
approved these changes
Sep 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file was pretty messy. Cleanups:
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
The diff is pretty hard to read, but it makes a lot more sense if you just look at the resulting file.