Add test for possible race in guard condition notification#280
Open
MiguelCompany wants to merge 2 commits into
Open
Add test for possible race in guard condition notification#280MiguelCompany wants to merge 2 commits into
MiguelCompany wants to merge 2 commits into
Conversation
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
|
Tick the box to add this pull request to the merge queue (same as
|
…times Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
|
Pulls: #280
|
|
Pulls: #280, ros2/rmw_fastrtps#895
|
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a test that checks that notifying 10 guard conditions from one thread while using
rmw_waitin another thread makes all conditions be notified exactly once.Is this user-facing behavior change?
Did you use Generative AI?
Additional Information
Due to the flaky nature of race conditions, the test shall be run with
--ctest-args --repeat until-fail:10to make it fail