fix non standard interface locations. (#1186)#1205
fix non standard interface locations. (#1186)#1205techtasie wants to merge 1 commit intoros2:kiltedfrom
Conversation
fujitatomoya
left a comment
There was a problem hiding this comment.
i believe that using this resource as the source of truth for lookup is much more robust than inferring paths from directory names. lgtm with green CI. i would like to have 2nd review on this before merge.
9dc3f85 to
0ed4876
Compare
|
@fujitatomoya, I have updated the package not found message and changed the expected test output for |
Signed-off-by: Tim Wendt <techtasie@gmail.com>
|
Pulls: #1205 |
|
this PR requires ros2/rosidl#935 1st. |
Description
Instead of relying on the broken
get_interface_pathfunction, I use therosidl_interfacesresource directly. (see explanation)Fixes #1186
Is this user-facing behavior change?
No
Did you use Generative AI?
No
Additional Information
For rolling, this issue will be resolved by changing the behavior of ros2idl in ros2/rosidl#935
This patch can be backported to Jazzy and humble.
I am unsure whether it is correct to fix this in ros2cli or whether the change should happen in
rosidl_runtime_py. Due to the huge number of packages that depend onrosidl_runtime_py, I am hesitant to make that change there, especially since packages rarely rely on the.msg/.srv/.actionfiles.