-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add reference to schema in generated permission files #84
add reference to schema in generated permission files #84
Conversation
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
I'd expect so. I don't know of another way the CLI could acquire the DDS schema without it being pre-installed, other than requiring users have constant internet access to the public internet 🌏 . Can we get it from the vendor installed? |
I remember that at least RTI and Fast-RTPS provide a version of these, not sure about Opensplice or other vendors.
I have nothing against the current solution about embedding it in the repo, just brainstorming if we could come up with anything avoiding duplication |
That sounds nice! Could we add a bit of logic to the setup.py to first check the source folder for it before downloading a version from OMG as a fall back. This would keep it easy for developers to use custom schemas, or test unreleased schemas in beta.
The fact the no XML template processor can use HTTPS was infuriating when I was prototyping! If we do scrape the XSD from OMG at build time, lets makes sure if via https though.
The XSD hasn't changed often TBH, I think the latest release merely added and optional |
Pulling it at build time sounds good to me. This will likely be a separate PR though as this one is just for consistency accross governance/permission xml files and allow end consumers to have a self-contained permission files. I would advocate to get this in as is as I don't know if/when I'll have time to work on the next step.
Yeah last change I remember was the renaming of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Feel free to merge when ready. Could you open a ticket for this so we don't forget. |
👍 #86 |
* Correct sros2 cli test folder location (#83) * Update test folder location fixing incomplete rebase from #72 * Remove old yaml profile examples fixing incomplete rebase from #72 * add reference to schema in generated permission files (#84) Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com> * Add missing attributes to test permissions XML file Signed-off-by: Jacob Perron <jacob@openrobotics.org> * fix status print to match commands invoked Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com> * Fix bug preventing generate_policy verb from working with publishers and services Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Add CMake lint test to sros2_cmake (#90) Fixed lint errors accordingly. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
This PR adds a reference to the schema used in the generated xml files (similar to what is in the default governance file) so that users can perform validation on the files.
@ruffsl It looks like this repo now has a copy of the permission and governance XSDs from the OMG website. Is the expected way of managing schema to commit new copies of the schemas to this repo when a new DDS Security version comes out?