Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing attributes to test permissions XML file #88

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

jacobperron
Copy link
Member

Resolves #87

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Feb 26, 2019
@jacobperron
Copy link
Member Author

CI (up to sros2):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Member

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with Green CI, thanks @jacobperron for getting this so quickly.

@jacobperron jacobperron merged commit 8165d7f into master Feb 26, 2019
@jacobperron jacobperron deleted the fix-sros2-test branch February 26, 2019 18:41
@jacobperron jacobperron removed the in review Waiting for review (Kanban column) label Feb 26, 2019
@ruffsl
Copy link
Member

ruffsl commented Feb 26, 2019

Seems we forgot to update the test example after updating the schema in #84 like we did for #80 . Still might want to use difflib to report a more readable test error in how the generated files differ.

https://docs.python.org/3.6/library/difflib.html

E.g

def display_diff_markdown(a, b, fromfile, tofile, n=4, lineterm=''):
    aa = a.splitlines()
    bb = b.splitlines()
    diffs = difflib.unified_diff(a=aa, b=bb, fromfile=fromfile, tofile=tofile, n=n, lineterm=lineterm)
    diff = '\n'.join(diffs)
    display(Markdown('``` diff\n' + diff + '\n```'))

display_diff_markdown(a=actual_str,
                      b=expected_str,
                      fromfile='actual',
                      tofile='expected')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants