Fix for issue #42 - missing parentheses in some expressions #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions
Example code where the issue is visible:
(function(){}()); --> the outer set of parens are dropped
(a=b,c=d,e=f); --> the outer set of parens are dropped
Both the issues are visible when node.to_ecma() is used.
Unittests for the dropping parens bug (Issue rspivak#42)
Contributor
|
Tested this locally and all the issues in #42 are fixed. +1 |
rspivak
added a commit
that referenced
this pull request
Mar 23, 2013
Fix for issue #42 - missing parentheses in some expressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.