perf(fmt): cache unsupported parser results - #239
Merged
Conversation
Deploying rstack-cli with
|
| Latest commit: |
5df6609
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://73cc499e.rstack-cli.pages.dev |
| Branch Preview URL: | https://chenjiahan-perf-fmt-cache-un.rstack-cli.pages.dev |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5df6609134
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR caches unsupported parser lookup results so repeated
rs fmtruns can skip files that Prettier cannot parse. Unsupported entries are keyed by file path and final formatting options, avoid content I/O, and are filtered before worker-pool startup while existing option, plugin, and formatter-version invalidation remains intact. On the Rspack repository, warm-cache mean latency improved by 4.2% across 60 runs, while a 5,000-unsupported-file stress case improved by 45.6%.