fix(vscode): apply trace.server live, drop stale rslint.json watcher, port unicode-bom E2E - #44
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
fi3ework
force-pushed
the
fix/lint-trace-json-watcher-bom
branch
from
September 3, 2026 12:59
591062f to
59ade6c
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 59ade6c18f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rstack.rslint.trace.serverlive throughvscode-languageclient, without restarting the language server.rstack.rslint.trace.serverto the window, matchingvscode-languageclient's URI-less configuration lookup and the existingrstack.fmt.trace.serverscope.rslint.json/rslint.jsoncconfig-refresh watcher entries now that Rslint no longer loads legacy JSON configs.Upstream provenance: rslint #1967 for live LSP tracing, rslint #1951 for removing legacy JSON config loading, and rslint #1560 for the Unicode BOM rule and editor coverage.
The language client id changes from
rslinttorstack.rslintbecausevscode-languageclientderives the trace setting namespace from that id. Without the rename, it would watch the unsupportedrslint.trace.serverkey instead ofrstack.rslint.trace.server.Related Links
Closes #39
Closes #41
Closes #42
Checklist
Testing
pnpm lint— exit 0:Found 0 lint errors, 0 type errors and 0 warnings (linted 165 files with 22 rules, type-checked 156 files in 290ms using 14 threads).pnpm test:unit— exit 0: 31 test files passed and 264 tests passed.RSTACK_LINT_E2E_SUITES="Trace output,unicode-bom,No config,JS config" VSCODE_CLI=1 pnpm test:e2e lint— exit 0: JS config, Trace output channel, No config, and unicode-bom suites all passed.Rstack lint bridgesuite: covered by CI after the rebase onto main (fixed there by chore: latest Rstack toolchain everywhere, exact fixture pins, Renovate bumps fixtures too #46).