chore: latest Rstack toolchain everywhere, exact fixture pins, Renovate bumps fixtures too - #46
Conversation
rslint#1851 changed the explicit-config path base in @rslint/core 0.8.2. rstack 0.6.1's shim has no basePath; rstack 0.7.2 sets basePath=process.cwd() via @rslint/core 0.9.0.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eb59cf2602
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fi3ework
changed the title
fi3ework
changed the title
…ates its lockfile
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d86fd9d846
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fi3ework
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5947fffd3a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… from tested releases in AGENTS.md The floor is reverted because the worker reads the discovery protocol from the selected core and forwards payloads unchanged, so 0.8.x keeps working; bridged projects are already held to 0.9.0 by rstack >=0.7.0; AGENTS.md now distinguishes tested-latest from evidence-based floors.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a2bfb6bad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Why
mainCI started failing on 2026-08-27 without any commit: theRstack lint bridgeE2E suite timed out waiting for a diagnostic that never arrived (#43).The fixture pinned
rstack@0.6.1, whose own dependency on@rslint/coreis the range~0.8.0. Fixtures install fresh on every run, so that range floated from 0.8.1 to 0.8.2 the day 0.8.2 was published.@rslint/core0.8.2 (web-infra-dev/rslint#1851) changed how an explicitly selected config resolves relative paths:files/ignoresare now relative to the config module's directory instead of the invocation cwd.rs lintin rstack 0.6.x passesnode_modules/rstack/dist/rslintConfig.jsas--config, and that shim exports the project'sdefine.lintentries with no path base, sofiles: ['src/**/*.ts']is matched fromnode_modules/rstack/dist/and matches nothing. Lint runs with zero rules and reports success; the extension's bridge takes the same path and shows a healthy Rslint with no diagnostics.Verified by A/B in isolated installs:
rs linton the fixtureno-debuggerreportedno-debuggerreportedrstack 0.7.0 is the first release whose shim sets
basePath = process.cwd()on every entry (rstackjs/rstack-cli#431), using the flat-configbasePathsupport added in@rslint/core0.9.0; 0.7.0 through 0.7.2 all pin@rslint/core@0.9.0exactly.Changes
rstack@0.7.2,@rslint/core@0.9.0,@rstest/core@0.11.11in all six fixture manifests (no^/~). Installs stay--no-frozen-lockfileand fixture lockfiles stay ignored; determinism now comes from the pins, andrstack@0.7.2pins its transitive@rslint/coreitself.rstack^0.7.2(contributor Node range follows rstack's own engines,^22.18.0 || >=24.3.0), extension@rslint/core^0.9.0and@rstest/core^0.11.11.^22.18.0 || >=24.3.0, excluding Node 23 and Node 24.0–24.2; unit coverage asserts it remains a subset of the installed rstack package'sengines.node.packages/vscode/e2e/**leavesignorePaths, so the immediaterstack toolchaingroup bumps root, devDependencies and fixture pins in one PR;rangeStrategy: bumprewrites an exact pin to the new exact version.rstack >=0.7.0(first release with thebasePathshim; 0.6.x users now get aversion mismatchstatus instead of a silent zero-rule lint).@rslint/core >=0.8.0and@rstest/core >=0.6.0are unchanged: the lint worker reads the discovery protocol version from the selected core and forwards payloads unchanged, so 0.8.x native projects keep working, and nothing in this PR touches the test stack.packages/vscode/AGENTS.mdnow separates "tests and fixtures track the latest release" from "floors are the lowest release the evidence supports".plugin-pool.test.tssendscollectFixes(required in the 0.9 plugin-lint protocol); comments that named protocol 2 no longer name a specific protocol.Related Links
Closes #43
Refs #40 — parts 1 (verify current releases) and 3 (keep fixtures on latest through Renovate) are done here; part 2 (rstack-ecosystem-ci) remains.
Checklist
Testing
pnpm --filter rstack test:e2e:fixtures— exit 0; all six fixtures install from the exact pins, generated lockfiles stay untracked.pnpm fmt:check,pnpm lint— exit 0 on rstack 0.7.2 (161 files, 22 rules).pnpm test:unit— exit 0,31 files / 260 testson Rstest 0.11.11.VSCODE_CLI=1 pnpm test:e2e smoke— exit 0; project-resolved@rslint/core@0.9.0produced the expectedlocal/no-nulldiagnostic.RSTACK_LINT_E2E_SUITES='Rstack lint bridge,eslintPlugins' VSCODE_CLI=1 pnpm test:e2e lint— exit 0; the bridge suite passes again on rstack 0.7.2.VSCODE_CLI=1 pnpm test:e2e rstest— exit 0 on@rstest/core@0.11.11.