Sync Main to Dev after 1.4.2 #1183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR synchronizes the main branch with dev after the 1.4.2 release, updating version numbers across all relevant files and implementing several fixes and improvements.
- Updated version number from 1.4.1 to 1.4.2 across all configuration files
- Added Safari/iOS compatibility fixes for video playback and source ordering
- Implemented conditional plugin loading to prevent conflicts and improved analytics tracking
Reviewed Changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| readme.txt | Updated stable tag and added v1.4.2 changelog entries |
| package.json | Bumped version to 1.4.2 |
| godam.php | Updated plugin version and constant definition |
| inc/templates/godam-player.php | Removed hardcoded video source elements |
| inc/classes/class-media-library-ajax.php | Updated @SInCE tag from placeholder to actual version |
| assets/src/js/godam-player/masterSettings.js | Added conditional import for quality levels plugin |
| assets/src/js/godam-player/managers/configurationManager.js | Added Safari/iOS video source reordering logic |
| assets/src/js/godam-player/analytics.js | Updated @SInCE tag from placeholder to actual version |
| assets/src/blocks/godam-player/VideoJS.js | Added conditional import for quality menu plugin |
| admin/class-rtgodam-transcoder-handler.php | Updated @SInCE tag from placeholder to actual version |
| README.md | Updated stable tag to 1.4.2 |
| CHANGELOG.md | Added v1.4.2 changelog entries |
| .github/workflows/release_on_tag.yml | Fixed file path references in release workflow |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+8
to
+11
| // Only import qualityMenu if not already registered (this will also load qualityLevels as dependency) | ||
| if ( ! videojs.getPlugin( 'qualityMenu' ) ) { | ||
| import( 'videojs-contrib-quality-menu' ); | ||
| } |
There was a problem hiding this comment.
The dynamic import() is asynchronous but not awaited. This could cause race conditions where the plugin might not be loaded when needed. Consider using a static import at the top level or properly handle the Promise returned by import().
Suggested change
| // Only import qualityMenu if not already registered (this will also load qualityLevels as dependency) | |
| if ( ! videojs.getPlugin( 'qualityMenu' ) ) { | |
| import( 'videojs-contrib-quality-menu' ); | |
| } | |
| import 'videojs-contrib-quality-menu'; |
KMchaudhary
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.