Sync Main to Develop #892
Merged
Sync Main to Develop #892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: VideoSEOModal attributes handling for GoDAM CMS and remove unused attachmentData * fix: prevent warning incase of attributes not being present * refactor: simplify SEO data extraction in VideoSEOModal and remove getFirstNonEmpty call * refactor: add documentation for VideoSEOModal component parameters
* feat: add transcoding job ID metadata to attachments * fix: remove transcoding job ID update and fallback to original ID in player template
refactor: code quality refactor: code quality refactor: modularize code feat: close menu on item selection chore: fix comments refactor: code quality refactor: code quality
* Fix: Ensure video speed and quality settings are player-specific * Refactor: Use logical nullish assignment
Patch/1.3.3
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR syncs the main branch to the develop branch following the 1.3.3 release. The changes include version updates, banner redesign, video player improvements, and various bug fixes.
- Version bump from 1.3.2 to 1.3.3 across all relevant files
- Redesigned annual plan offer banner with particle animation effects
- Improved video player settings with better state management and SEO support
Reviewed Changes
Copilot reviewed 22 out of 24 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| readme.txt | Updated version to 1.3.3, added new contributors, and changelog entry |
| package.json | Version bump to 1.3.3 |
| godam.php | Version constant updated to 1.3.3 |
| languages/godam.pot | Updated version and added new translation strings |
| assets/src/css/admin.scss | Added comprehensive styling for redesigned banner with particle effects |
| assets/src/js/admin.js | Added particle animation system and improved admin UI initialization |
| pages/video-editor/AttachmentPicker.jsx | Replaced banner image with text-based banner design |
| assets/src/js/godam-player/masterSettings.js | Improved video player settings with better state management |
| assets/src/blocks/godam-player/edit.js | Enhanced video SEO support and GoDAM tab integration |
| inc/classes/class-media-library-ajax.php | Refactored banner HTML generation and removed deprecated functionality |
| constructor( player, options ) { | ||
| super( player, options ); | ||
| this.player_ = player; | ||
| this.player_.selectedSpeed ??= '1x'; |
There was a problem hiding this comment.
Using nullish coalescing assignment operator (??=) might not be supported in all target browsers. Consider checking browser compatibility or using a more compatible approach like this.player_.selectedSpeed = this.player_.selectedSpeed || '1x';.
Suggested change
| this.player_.selectedSpeed ??= '1x'; | |
| this.player_.selectedSpeed = this.player_.selectedSpeed || '1x'; |
| 'id' => $item['name'], | ||
| 'title' => pathinfo( $item['orignal_file_name'], PATHINFO_FILENAME ) ?? $item['name'], | ||
| 'title' => isset( $item['orignal_file_name'] ) ? pathinfo( $item['orignal_file_name'], PATHINFO_FILENAME ) : $item['name'], | ||
| 'filename' => $item['orignal_file_name'] ?? $item['name'], |
There was a problem hiding this comment.
The array key 'orignal_file_name' appears to be misspelled. It should likely be 'original_file_name'.
Suggested change
| 'filename' => $item['orignal_file_name'] ?? $item['name'], | |
| 'title' => isset( $item['original_file_name'] ) ? pathinfo( $item['original_file_name'], PATHINFO_FILENAME ) : $item['name'], | |
| 'filename' => $item['original_file_name'] ?? $item['name'], |
|
|
||
| // Initialize particles based on the canvas size | ||
| initParticles( count ) { | ||
| const maxParticles = Math.min( count, Math.floor( this.width / 20 ) ); |
There was a problem hiding this comment.
The magic number 20 used for particle density calculation should be extracted to a constant or configuration variable to improve maintainability and make the calculation more explicit.
Suggested change
| const maxParticles = Math.min( count, Math.floor( this.width / 20 ) ); | |
| const maxParticles = Math.min( count, Math.floor( this.width / ParticleEffect.PARTICLE_DENSITY_DIVISOR ) ); |
KMchaudhary
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to sync Main to Develop after 1.3.3 Release