Skip to content

Conversation

@depfu
Copy link
Contributor

@depfu depfu bot commented May 23, 2018

We've upgraded a dependency and got test failures.

name version specification new version
faraday < 0.15.0, >= 0.8 0.15.2

It looks like this version isn't compatible with your project right now. Please take a look at the exact failure to figure out if this is something you need to work on.

What changed?

✳️ faraday ( → 0.15.2) · Repo · Changelog

Release Notes

From the Github release:

  • Prevents Net::HTTP adapters to retry request internally by setting max_retries to 0 if available (Ruby 2.5+). (#799)
  • Fixes NestedParamsEncoder handling of empty array values (#801)
Commits

See the full diff on Github. The new version differs by 3 commits:


Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

Depfu Status

@coveralls
Copy link

coveralls commented May 23, 2018

Pull Request Test Coverage Report for Build 624

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 618: 0.0%
Covered Lines: 309
Relevant Lines: 309

💛 - Coveralls

@pboling
Copy link
Member

pboling commented Aug 5, 2018

Fixed by #397

@pboling pboling closed this Aug 5, 2018
@depfu depfu bot deleted the depfu/update/faraday-0.15.2 branch August 5, 2018 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants