Update Mac to draft 05 #509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I see #196 inactive for a long time, so I remake. |
Pull Request Test Coverage Report for Build 1029
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1015
💛 - Coveralls |
anvox
commented
Jun 11, 2020
| # @option opts [FixNum, String] :algorithm (hmac-sha-256) the algorithm to use for the HMAC digest (one of 'hmac-sha-256', 'hmac-sha-1') | ||
| def initialize(client, token, secret, opts = {}) | ||
| @secret = secret | ||
| @seq_nr = SecureRandom.random_number(2 ** 64) |
Member
Author
There was a problem hiding this comment.
Sequence numbers fall in the range 0 through 2^64 - 1 and wrap to zero following the value 2^64 - 1.
As SecureRandom.random_number(n) generate number => 0 and < n, we needn'nt minus 1
Member
|
@anvox This looks great! This appears to be a breaking change? Would you suggest a minor release, or a major release? How "breaking" is this change? |
Closed
anvox
force-pushed
the
av-update-mac-to-draft-5
branch
from
01e8125 to
f1150fc
Compare
Member
Author
|
@pboling I think it should be a major change. By this change, we no longer support MAC token draft < 3. Clients must |
Member
|
@anvox ok, this will be a new major release of 2.0.0, and the old major milestones will all get bumped up by +1.0.0 |
This was referenced Mar 28, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remake #196 with a little change in detail.
See comments.
Implement #194