Earlier release of 2.0?

[stanhu]

@pboling Thanks for all your work here! I'd love to get a release 2.0, particularly to pull in #509 since this gets rid of MD5, which is necessary for FIPS compliance.

I see https://github.com/oauth-xx/oauth2/milestone/1 is the goal, but could we push these to a 2.1 release?

[stanhu]

Are #582 and #248 the main issues that need help?

[pboling]

I wasn't aware of the FIPS compliance issue. I will check the milestone and see what looks reasonable. Those two issues, definitely need attention.

[stanhu]

Ok, I think the 2.0 issues are complete now. I think the mutual TLS issue can probably be left alone now: #583 (comment). As far as I can tell, no code changes are necessary on the client.

Could we cut a release soon? Thanks again!

[pboling]

Everything looks great! I'll start the release process 🎸

[pboling]

@stanhu I have released 2.0.0.rc1. Please try it out!

[stanhu]

@pboling Thank you!

I did a diff between v1.4.9 and v2.0.0.rc1:

• In v1.4.9, if there were a JSON or XML parser error in #get_token, the client would catch the exception and return nil. In v2.0.0.rc1 I think the parser exception gets raised? I'm wondering if this is could lead to errors bubbling up unexpectedly.
• Wondering if OAuth2::Client#refresh! should use a keyword argument access_token_class to be consistent with OAuth2::Client#get_token.

[stanhu]

Ok, I see raise_errors was default to true, so the exception would be thrown in v1.4.9 as well.

[pboling]

@stanhu On the first point, raising was an intentional breaking change. #576

[pboling]

On the second point, yeah, I think it makes sense to have the arguments share a common pattern.

[stanhu]

#595 should resolve a regression, and #596 should make the arguments consistent.

[pboling]

I will have a look at them when I get back to my computer!

[pboling]

@stanhu 2.0.0.rc2 has been released with those changes

[stanhu]

@pboling Thank you! One more bug fix with error handling: #598

[pboling]

@stanhu 2.0.0.rc3 is released!