Add an ASCII fast path for String#casecmp? - #17444
Merged
Merged
Conversation
String#casecmp? folds both operands with a Unicode case fold, allocating two new strings, and compares the results. For ASCII-only strings, Unicode case folding is equivalent to ASCII case-insensitive comparison, so the operands can be compared byte-by-byte without allocating anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String#casecmp?folds both operands with a Unicode case fold, allocating two new strings, and compares the results. For ASCII-only strings, Unicode case folding is equivalent to ASCII case-insensitive comparison, so the operands can be compared byte-by-byte without allocating anything.#casecmpis older and does not take Unicode into account, which makes it faster. So this will add a fast path to#casecmp?so that the performance will be around the same. Turned off GC for that benchmark as it made the bench noisy (like inruby/benchmark/string_concat.yml).Benchmark
Apple M1 Pro (arm64-darwin)
Docker Linux (aarch64-linux)
AMD Ryzen 7 5700G (8C/16T) — Windows 11 (x64-mingw-ucrt, gcc 16.1.0, MSYS2 UCRT64)
Non-ASCII (fast path not taken) is unchanged: