ZJIT: Export build-dependent struct offsets as a const table - #18256
Merged
Conversation
XrXr
approved these changes
Aug 7, 2026
eightbitraptor
approved these changes
Aug 7, 2026
# Conflicts: # zjit.c # zjit/src/codegen/gc_fastpath.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose an alternative to how we currently import offsets that very between x86_64 and arm64 #18241 (comment). Instead of defining a C function for every offset in the Ractor struct, this PR defines a const struct compiled by the C compiler, which is readable without a C call from Rust.
This is probably performance-neutral, if not slightly faster, but you will no longer need to enumerate these function names in
zjit/src/cruby.rs(orzjit/bindgen/src/main.rs) anymore. Just modifyingzjit.calone would letmake zjit-bindgenimport new offsets, which takes less effort than the current setup.