Skip to content

Copy of #2362 - #2752

Merged
mame merged 23 commits into
ruby:masterfrom
jinroq:add_kwarg3_doc_copy
Nov 29, 2021
Merged

Copy of #2362#2752
mame merged 23 commits into
ruby:masterfrom
jinroq:add_kwarg3_doc_copy

Conversation

@jinroq

@jinroq jinroq commented Nov 27, 2021

Copy link
Copy Markdown
Contributor

Copy of #2362 .
@hachi8833

Revised the points pointed out in the review.

@jinroq
jinroq requested a review from a team as a code owner November 27, 2021 00:05
@mame

mame commented Nov 29, 2021

Copy link
Copy Markdown
Member

Thank you! Could you please rebase the pull request? Then I'll merge it soon.

@jinroq
jinroq requested a review from a team as a code owner November 29, 2021 01:58
@jinroq

jinroq commented Nov 29, 2021

Copy link
Copy Markdown
Contributor Author

@mame I did it.

@mame
mame merged commit 1a64c6a into ruby:master Nov 29, 2021
@mame

mame commented Nov 29, 2021

Copy link
Copy Markdown
Member

Thanks!

@jinroq
jinroq deleted the add_kwarg3_doc_copy branch November 29, 2021 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants