Drop obsolete unused-import workaround - #1001
Merged
Merged
Conversation
The `#[cfg(not(test))]` guard on the secp256k1 imports worked around a unused_imports warning tracked in rust-lang/rust#121684. That bug is fixed, so the guard is no longer needed.
satsfy
force-pushed
the
fix-unused-import-comment
branch
from
July 10, 2026 14:35
eea0c62 to
f6c5610
Compare
Contributor
Author
|
Force push rebases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
#[cfg(not(test))]guard on the secp256k1 imports worked around anunused_importswarning tracked in rust-lang/rust#121684 (2024). That bug is fixed, so the guard is no longer needed.Built with
cargo +nightly-2026-06-26 build --all-targets, a recent nightly version, and had no warning.This is not a priority at all, but I caught it during a codebase read.