Add Revspec::into_objects() and tests#1230
Merged
weihanglo merged 2 commits intorust-lang:masterfrom Apr 22, 2026
Merged
Conversation
weihanglo
approved these changes
Apr 22, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
Hmm, I guess there was a race condition in the test from #1237 ? Will send a patch in a minute to just remove that test, it isn't really important |
DanielEScherzer
force-pushed
the
revspec-into-options
branch
from
fcbc02b to
972d177
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
rebased on top of the removal of the flaky test |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1147