Skip to content

Tests: remove email_env_var() test from repo.rs#1240

Merged
weihanglo merged 1 commit intorust-lang:masterfrom
DanielEScherzer:drop-flaky-test
Apr 22, 2026
Merged

Tests: remove email_env_var() test from repo.rs#1240
weihanglo merged 1 commit intorust-lang:masterfrom
DanielEScherzer:drop-flaky-test

Conversation

@DanielEScherzer
Copy link
Copy Markdown
Contributor

Seems to be flaky, and covers internal libgit2 logic

Seems to be flaky, and covers internal libgit2 logic
@rustbot rustbot added the S-waiting-on-review Status: Waiting on review label Apr 22, 2026
@DanielEScherzer
Copy link
Copy Markdown
Contributor Author

Cross link #1230 where this caused the merge queue to fail
Cross link #1237 where the test was added

Copy link
Copy Markdown
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable. They are just thin wrappers.

View changes since this review

@weihanglo weihanglo enabled auto-merge April 22, 2026 22:59
@weihanglo weihanglo added this pull request to the merge queue Apr 22, 2026
Merged via the queue into rust-lang:master with commit 8e90ee0 Apr 22, 2026
7 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Waiting on review label Apr 22, 2026
@DanielEScherzer DanielEScherzer deleted the drop-flaky-test branch April 22, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants