Skip to content

Implement Repository::author_from_env() and ::committer_from_env()#1237

Merged
weihanglo merged 1 commit intorust-lang:masterfrom
DanielEScherzer:sig-from-env
Apr 22, 2026
Merged

Implement Repository::author_from_env() and ::committer_from_env()#1237
weihanglo merged 1 commit intorust-lang:masterfrom
DanielEScherzer:sig-from-env

Conversation

@DanielEScherzer
Copy link
Copy Markdown
Contributor

Expose the upstream functionality of git_signature_default_from_env()

Closes #1126

Expose the upstream functionality of `git_signature_default_from_env()`

Closes rust-lang#1126
@rustbot rustbot added the S-waiting-on-review Status: Waiting on review label Apr 22, 2026
@DanielEScherzer
Copy link
Copy Markdown
Contributor Author

@rustbot label "+new bindings"

@rustbot rustbot added the new bindings Missing bindings for existing libgit2 functions. label Apr 22, 2026
Copy link
Copy Markdown
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just one question.

View changes since this review

Comment thread src/repo.rs
@weihanglo weihanglo added this pull request to the merge queue Apr 22, 2026
Merged via the queue into rust-lang:master with commit 382f1e8 Apr 22, 2026
7 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Waiting on review label Apr 22, 2026
@DanielEScherzer DanielEScherzer deleted the sig-from-env branch April 22, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new bindings Missing bindings for existing libgit2 functions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose upstream git_signature_default_from_env

3 participants