Skip to content

infra: document instructions for yubikeys and piv - #1086

Merged
ubiratansoares merged 3 commits into
masterfrom
u/hw-keys-piv
Aug 4, 2026
Merged

infra: document instructions for yubikeys and piv#1086
ubiratansoares merged 3 commits into
masterfrom
u/hw-keys-piv

Conversation

@ubiratansoares

@ubiratansoares ubiratansoares commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Closes rust-lang/team#2501

AI usage disclaimer : the original text was fully written by me. I used an LLM to proofread it and I adopted grammar corrections and minor stylistic suggestions I got from the tool.

r? @marcoieni

Rendered

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 28, 2026

@marcoieni marcoieni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments.

Ai disclosure

I found most of the typos with AI.

View changes since this review

Comment thread src/infra/docs/hardware-security-keys.md
Comment thread src/infra/docs/hardware-security-keys.md Outdated
Comment thread src/infra/docs/hardware-security-keys.md Outdated
Comment thread src/infra/docs/hardware-security-keys.md Outdated
Comment thread src/infra/docs/hardware-security-keys.md Outdated
Comment thread src/infra/docs/hardware-security-keys.md Outdated
Comment thread src/infra/docs/hardware-security-keys.md Outdated
Comment thread src/infra/docs/hardware-security-keys.md Outdated
Comment thread src/infra/docs/hardware-security-keys.md Outdated
Comment thread src/infra/docs/hardware-security-keys.md Outdated

@marcoieni marcoieni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some simplifications found mainly with AI, so that it is easier to read this document.

View changes since this review

Comment thread src/infra/docs/hardware-security-keys.md Outdated
Comment thread src/infra/docs/hardware-security-keys.md Outdated
Comment thread src/infra/docs/hardware-security-keys.md Outdated
Comment thread src/infra/docs/hardware-security-keys.md Outdated
Comment thread src/infra/docs/hardware-security-keys.md Outdated
Comment thread src/infra/docs/hardware-security-keys.md Outdated
Comment thread src/infra/docs/hardware-security-keys.md Outdated
Comment thread src/infra/docs/hardware-security-keys.md Outdated
Comment thread src/infra/docs/hardware-security-keys.md Outdated
Comment thread src/infra/docs/hardware-security-keys.md Outdated
@ubiratansoares

Copy link
Copy Markdown
Contributor Author

@marcoieni if I'm not missing anything else, happy to squash some commits

@marcoieni marcoieni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, yes, feel free to merge this after you squash the commits 👍

View changes since this review

@ubiratansoares
ubiratansoares merged commit 9fd9334 into master Aug 4, 2026
1 check passed
@ubiratansoares
ubiratansoares deleted the u/hw-keys-piv branch August 4, 2026 19:04
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support storing hardware keys attestations files from team members

3 participants