Don't fix paths after running cargo. #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Rust 1.12, Cargo now emits paths that are relative to the current directory, not Cargo.toml, so the path rewriting is no longer necessary. In some repository layouts with multiple crates in a workspace, relative paths would be rewritten relative to the wrong crate's Cargo.toml. Also remove the documentation for the g:cargo_manifest_name option which isn't used any more.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Contributor
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, vim started reporting Rust compilation errors in non-existent filenames in my multi-crate repository. Possibly after I installed rustc 1.12. The problem is caused by the FixPaths function in compiler/cargo.vim which would rewrite
Cargo.toml-relative paths to current directory-relative paths. However, it would use the wrongCargo.toml.Cargo now emits paths that are relative to the current directory, not
Cargo.toml, so the path rewriting is no longer necessary.Also remove the documentation for the
g:cargo_manifest_namesetting which isn't used any more.