Skip to content

Conversation

@borisfaure
Copy link

With cargo from rust 1.12.1 (but behaviour might have changed in earlier
versions), cargo is calling rustc with path related to the current
directory. There is no longer need to call FixPaths()
I had issue with FixPath because I'm calling cargo build from the src/
directory but FixPath would show errors on paths that do no contain src/.

With cargo from rust 1.12.1 (but behaviour might have changed in earlier
versions), cargo is calling rustc with path related to the current
directory. There is no longer need to call FixPaths()
I had issue with FixPath because I'm calling cargo build from the src/
directory but FixPath would show errors on paths that do no contain src/.
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @chris-morgan (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@jpernst
Copy link
Contributor

jpernst commented Nov 14, 2016

I've been having intermittent problems with quickfix errors opening incorrect files or files that don't even exist, particularly when working on a project with nested crates. Took a while to finally track down the cause, and FixPaths was the culprit. I've applied this patch and the issue is resolved, so +1 from me.

@steveklabnik
Copy link
Contributor

I've merged #116 which seems to do much the same thing. What do you think, @billiob ?

@borisfaure
Copy link
Author

Looks fine.

@borisfaure borisfaure closed this Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants