Clippy subtree update #147779
Open
Clippy subtree update #147779
+7,417
−2,694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Volatile reads and writes to non-primitive types are not well-defined, and can cause problems. See rust-lang/rust-clippy#15529 for more details.
switch around `*_amount` and `*_expr` -- otherwise the order gets confusing now because of both of them being `Expr`s
this is kind of a side-effect of the next commit
changelog: none Signed-off-by: Zihan <zihanli0822@gmail.com>
now lints on
```rs
let mut x = [1,2,3].into_iter();
loop {
let Some(x) = x.next() else { break };
dbg!(x);
}
```
```
changelog: [`while_let_loop`]: extend to lint on `let else`
```
Volatile reads and writes to non-primitive types are not well-defined, and can cause problems. Fixes rust-lang/rust-clippy#15529 changelog: [`volatile_composites`]: Lint when read/write_volatile is used on composite types (structs, arrays, etc) as their semantics are not well defined.
Remove no-rustfixes where it's not required anymore changelog: none
…avidtwco test: Subtract code_offset from width for ui_testing `annotate-snippets` does not have a "UI test" mode like `rustc`, [where the code offset is not subtracted from the column width](https://github.com/rust-lang/rust/blob/f34ba774c78ea32b7c40598b8ad23e75cdac42a6/compiler/rustc_errors/src/emitter.rs#L1985-L1987). This makes it so `annotate-snippets` will shift the output for some very long tests 5 - 7 columns to the left. As part of my work to have `rustc` use `annotate-snippets`, and to reduce the test differences between the two, I figured it would be best if `rustc` started subtracting the code offset from the width as well. The first commit exists to keep the test output changes of adding a new line to a test separate from adding the `--diagnostic-width` flag in the second commit. This makes it easier to verify that adding the flag does not affect the test's output. [Zulip discussion](https://rust-lang.zulipchat.com/#narrow/channel/147480-t-compiler.2Fdiagnostics/topic/annotate-snippets.20hurdles)
changelog:none
…ang#15816) Fixes rust-lang/rust-clippy#15805 ICE bisects to 9457d64, which handles the span incorrectly when part of the path originates from internal declarative macro. changelog: none
…rn suggestions (rust-lang#15608) Fixes rust-lang/rust-clippy#13287 changelog: [`collapsible_match`]: exclude binding modes from struct field pattern suggestions
Adds a new lint that detects `var = Default::default()` when `var` is `Box<T>` and `T` implements `Default`. changelog: [`replace_box`]: new lint
…-lang#15547) Closes rust-lang/rust-clippy#14550 Closes rust-lang/rust-clippy#15548 changelog: [`needless_continue`] fix FP when match type is not unit or never
|
@bors r+ p=1 rollup=never |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 16, 2025
Clippy subtree update r? `@Manishearth` `Cargo.lock` update, because `clippy_utils` is now also using `itertools`
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
flip1995
force-pushed
the
clippy-subtree-update
branch
from
9895efc to
4b0cfb6
Compare
|
The above issue should be fixed now. |
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 16, 2025
Clippy subtree update r? `@Manishearth` `Cargo.lock` update, because `clippy_utils` is now also using `itertools`
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
It looks like the test that made it fail is spuriously failing a lot. @bors retry |
bors
added
S-waiting-on-bors
|
(I've open this Zulip thread on the repeated failure of the mingw test) |
bors
added a commit
that referenced
this pull request
Oct 17, 2025
Clippy subtree update r? `@Manishearth` `Cargo.lock` update, because `clippy_utils` is now also using `itertools`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
30 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Manishearth
Cargo.lockupdate, becauseclippy_utilsis now also usingitertools