Skip to content

Conversation

@Zalathar
Copy link
Contributor

@Zalathar Zalathar commented Oct 23, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

clarfonthey and others added 7 commits October 23, 2025 08:51
As these characters are specifically called out in the RFC, I felt it
would be important to have a test to cover them.
…, r=cuviper

Revert constification of `Borrow` and `Deref for Cow` due to inference failure

Reported issue: rust-lang#147964
Original PR: rust-lang#145279
Previous revert: rust-lang#148011
`const Borrow`/`Deref` tracking issue: rust-lang#143773

Should have additional crater run to verify this fixes the issue.

Since other PR is in the queue, this will need to be rebased after that merges. Also will want a beta nomination.
…thanBrouwer

Add myself to the review rotation
test(frontmatter): Cover spaces between infostring parts

As these characters are specifically called out in the RFC, I felt it would be important to have a test to cover them.

Tracking issue: rust-lang#136889
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 23, 2025
@Zalathar
Copy link
Contributor Author

Rollup of everything.

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Oct 23, 2025

📌 Commit f4cb48c has been approved by Zalathar

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2025
@bors
Copy link
Collaborator

bors commented Oct 24, 2025

⌛ Testing commit f4cb48c with merge 80d46c5...

bors added a commit that referenced this pull request Oct 24, 2025
Rollup of 3 pull requests

Successful merges:

 - #148016 (Revert constification of `Borrow` and `Deref for Cow` due to inference failure)
 - #148039 (Add myself to the review rotation)
 - #148042 (test(frontmatter): Cover spaces between infostring parts)

r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-mingw-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
---- [run-make] tests\run-make\share-generics-export-again stdout ----

error: rmake recipe failed to complete
status: exit code: 1
command: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\share-generics-export-again\\rmake.exe"
stdout: none
--- stderr -------------------------------
command failed at line 22
Command { cmd: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\share-generics-export-again\\rmake_out" "--crate-type" "rlib" "foo.rs" "-Zshare-generics=yes" "--target=x86_64-pc-windows-gnu", stdin_buf: None, stdin: None, stdout: None, stderr: None, drop_bomb: DropBomb { command: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe", defused: true, armed_location: Location { file: "D:\\a\\rust\\rust\\tests\\run-make\\share-generics-export-again\\rmake.rs", line: 22, column: 5 } }, already_executed: true }
output status: `exit code: 0xc00000fd`
=== STDOUT ===



=== STDERR ===

---

Some tests failed in compiletest suite=run-make mode=run-make host=x86_64-pc-windows-gnu target=x86_64-pc-windows-gnu
Bootstrap failed while executing `test --stage 2 --skip=compiler --skip=src`
Build completed unsuccessfully in 2:31:39
make: *** [Makefile:123: ci-mingw-x] Error 1
  local time: Fri Oct 24 03:19:14 CUT 2025
  network time: Fri, 24 Oct 2025 03:19:15 GMT
##[error]Process completed with exit code 2.
##[group]Run echo "disk usage:"
echo "disk usage:"

@bors
Copy link
Collaborator

bors commented Oct 24, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 24, 2025
@Zalathar
Copy link
Contributor Author

Probably bogus, but let's do a try job:

@bors try jobs=x86_64-mingw-1

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Oct 24, 2025
Rollup of 3 pull requests

try-job: x86_64-mingw-1
@rust-bors
Copy link

rust-bors bot commented Oct 24, 2025

☀️ Try build successful (CI)
Build commit: fcd3eee (fcd3eeeb3e50b4ef16b8bf015e4217daac26c425, parent: 27050c0d15af664cf43ce4b0badec230e0bfcac5)

@Zalathar Zalathar closed this Oct 24, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 24, 2025
@Zalathar Zalathar deleted the rollup-7y9yo35 branch October 24, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants