Skip to content

[rustdoc search] Include extern crates when filtering on import #148301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[rustdoc search] Include extern crates when filtering on import #148301

wants to merge 2 commits into from
+29 −0

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Oct 30, 2025 •
edited by rustbot
Loading

As discussed #147909, some filters should have been "grouped". This PR allows extern crates to match the import filter.

This PR also allowed me to uncover a bug for the URL generated for renamed extern crates. Opened #148300 for it.

r? @notriddle

@rustbot
Copy link
Collaborator

rustbot commented Oct 30, 2025

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha, @lolbinarycat

@rustbot rustbot added A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Oct 30, 2025
@GuillaumeGomez GuillaumeGomez added the relnotes Marks issues that should be documented in the release notes of the next release. label Oct 30, 2025
@rustbot rustbot mentioned this pull request Oct 30, 2025
Open
notriddle
notriddle reviewed Oct 31, 2025
View reviewed changes
@GuillaumeGomez
Copy link
Member Author

Added comment.

@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 1, 2025

📌 Commit 2a1595e has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@notriddle notriddle notriddle left review comments

Assignees

@notriddle notriddle

Labels

A-rustdoc-search Area: Rustdoc's search feature relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez @rustbot @notriddle @bors