rustdoc: quality of life changes #148466
rustdoc: quality of life changes #148466
Conversation
|
Some changes occurred in HTML/CSS/JS. |
rustbot
added
S-waiting-on-review
|
r? @notriddle rustbot has assigned @notriddle. Use |
| autocomplete="off" | ||
| spellcheck="false" | ||
| placeholder="Type ‘S’ or ‘/’ to search, ‘?’ for more options…" | ||
| placeholder="Search API docs" |
There was a problem hiding this comment.
I'd prefer to keep it as is until we come up with a solution on how to tell people that this shortcut exists.
There was a problem hiding this comment.
Already told to people by help button.
There was a problem hiding this comment.
I don't think the current placeholder is a good idea at all.
- It's shown auto-focused, which is confusing just like liigo says.
- It's telling you how to open search mode after search mode is already open, which is too late to be useful.
In other words, I agree with the change in this PR.
There was a problem hiding this comment.
Discovering a shortcut while using a feature is better than hiding it all the time. The help menu is not a good place to discover shortcuts sadly. Also, when the input is focused, as long as it's empty, the placeholder is displayed (at least on firefox).
| ["← / →", "Switch result tab (when results focused)"], | ||
| ["⏎", "Go to active search result"], | ||
| ["+", "Expand all sections"], | ||
| ["+ / =", "Expand all sections"], |
There was a problem hiding this comment.
We generally avoid adding new shortcuts to not overwrite existing browser/user's shortcuts.
There was a problem hiding this comment.
the current + shortcut is not just only +, it's really shift+=.
There was a problem hiding this comment.
User press - (no shift needed), it works. But if he press + (without shift), it not works, this is a bit weird, or not convenient.
There was a problem hiding this comment.
It works with just + for me without shift.
There was a problem hiding this comment.
That's not the case for me on firefox, what browser and keyboard layout are you using?
There was a problem hiding this comment.
Very strange, that's the same here, you don't happen to have any extensions or userscripts that could be changing that behavior, do you?
What's your exact browser version?
There was a problem hiding this comment.
Only adblock. Version 143.0.3.
There was a problem hiding this comment.
Ah ok, I understand the issue now. It's because I use the numpad. Well I guess = is fine then.
5 participants
=shortcut (alongside+) to expand all sections. Already supportsandS,Shiftor not.