Clippy subtree update #148957
Open
Clippy subtree update #148957
+4,913
−3,519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Their meanings, and the way they're handled in `get_attr`, are pretty similar
- Move it and its helper function `parse_attrs` together to the end of the file, because it's surprising to see front-and-center a struct that's only really used in one place (`cognitive_complexity`). - Avoid panic path in `LimitStack::limit` - Replace `assert` with `debug_assert` to avoid panics in release builds
Reduces code repetition
Now we don't touch, and thus don't break, whatever path `Rc`/`Arc` was specified with
Move `unused_enumerate_index.rs` to `methods`.
Fix rust-lang/rust-clippy#14350 Co-authored-by: Timo <30553356+y21@users.noreply.github.com>
…dead Constify trait aliases Allow `const trait Foo = Bar + [const] Baz;` trait alias declarations. Their rules are the same as with super traits of const traits. So `[const] Baz` or `const Baz` is only required for `[const] Foo` or `const Foo` bounds respectively. tracking issue rust-lang#41517 (part of the general trait alias feature gate, but I can split it out into a separate const trait alias feature gate. I just assumed that const traits would stabilize before trait aliases, and we'd want to stabilize trait aliases together with const trait aliases at the same time) r? ``@compiler-errors`` ``@fee1-dead``
not really necessary Follow-up to rust-lang/rust-clippy#15803 changelog: none r? @llogiq
Alternative to part of rust-lang/rust-clippy#14509. changelog: none
r? @ghost changelog: none
Collaborator
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
rustbot
added
S-waiting-on-review
Collaborator
|
Member
Author
|
@madsmtm could you take a look at the |
flip1995
commented
Nov 15, 2025
Comment on lines
+121
to
+123
| // FIXME: This should not be affected by the attribute on the function above. | ||
| fn bloo() { | ||
| //~^ cognitive_complexity |
Member
Author
There was a problem hiding this comment.
This shouldn't have started linting. But it is too late here and I'm pretty exhausted from this week to try to look into what changed in the check_attributes_after behavior of a restriction lint...
Member
Author
|
cc @RalfJung This syncs the MSRV fixes, that you need. Sorry for the 1+ day delay. |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
|
@bors r+ p=1 rollup=never |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Nov 15, 2025
Clippy subtree update r? `@Manishearth`
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
32 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Manishearth