-
Notifications
You must be signed in to change notification settings - Fork 14k
Tweak Motor OS linker preset, fix remote-test-server for Motor OS
#148999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
These commits modify compiler targets. |
This comment has been minimized.
This comment has been minimized.
Had to tweak linking options in target spec to make it work (see moturus/motor-os#46).
85f8f33 to
02770b3
Compare
|
Some context where this was discussed: https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/.E2.9C.94.20Error.20linking.20remote-test-server/with/556702546 |
remote-test-server for Motor OS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks fine to me
|
@bors r+ rollup |
|
(I edited your PR title, because the more significant change is changing the compiler target linker preset, not |
Rollup of 11 pull requests Successful merges: - #148505 (add larger test for `proc_macro` `FromStr` implementations) - #148752 (Constify `ManuallyDrop::take`) - #148757 (Constify `mem::take`) - #148855 (Error if an autodiff user does not set lto=fat) - #148912 (add note to `lines` docs about empty str behavior) - #148958 (Run codegen tests on a 32-bit target in PR CI) - #148994 (Abi compatibility test cleanup) - #148999 (Tweak Motor OS linker preset, fix `remote-test-server` for Motor OS) - #149004 (compiletest: Avoid race condition in file deletion) - #149008 (triagebot: remove jsha from notifications for rustdoc HTML) - #149010 (compiletest: Remove the "wasm32-bare" alias for `wasm32-unknown-unknown`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #148999 - moturus:remote-test-server, r=jieyouxu Tweak Motor OS linker preset, fix `remote-test-server` for Motor OS Had to tweak linking options in target spec to make it work (see moturus/motor-os#46).
Rollup of 11 pull requests Successful merges: - rust-lang/rust#148505 (add larger test for `proc_macro` `FromStr` implementations) - rust-lang/rust#148752 (Constify `ManuallyDrop::take`) - rust-lang/rust#148757 (Constify `mem::take`) - rust-lang/rust#148855 (Error if an autodiff user does not set lto=fat) - rust-lang/rust#148912 (add note to `lines` docs about empty str behavior) - rust-lang/rust#148958 (Run codegen tests on a 32-bit target in PR CI) - rust-lang/rust#148994 (Abi compatibility test cleanup) - rust-lang/rust#148999 (Tweak Motor OS linker preset, fix `remote-test-server` for Motor OS) - rust-lang/rust#149004 (compiletest: Avoid race condition in file deletion) - rust-lang/rust#149008 (triagebot: remove jsha from notifications for rustdoc HTML) - rust-lang/rust#149010 (compiletest: Remove the "wasm32-bare" alias for `wasm32-unknown-unknown`) r? `@ghost` `@rustbot` modify labels: rollup
Had to tweak linking options in target spec to make it work (see moturus/motor-os#46).