Skip to content

Conversation

@lasiotus
Copy link
Contributor

Had to tweak linking options in target spec to make it work (see moturus/motor-os#46).

@rustbot
Copy link
Collaborator

rustbot commented Nov 16, 2025

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 16, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 16, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

Had to tweak linking options in target spec to make it work
(see moturus/motor-os#46).
@Kobzol
Copy link
Member

Kobzol commented Nov 16, 2025

@jieyouxu jieyouxu changed the title remote-test-server: make it build for Motor OS Tweak Motor OS linker preset, fix remote-test-server for Motor OS Nov 17, 2025
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks fine to me

View changes since this review

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 17, 2025

📌 Commit 02770b3 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 17, 2025
@jieyouxu
Copy link
Member

(I edited your PR title, because the more significant change is changing the compiler target linker preset, not remote-test-server itself.)

@jieyouxu jieyouxu added the O-motor-os Operating system: Motor OS, https://doc.rust-lang.org/nightly/rustc/platform-support/motor.html label Nov 17, 2025
bors added a commit that referenced this pull request Nov 17, 2025
Rollup of 11 pull requests

Successful merges:

 - #148505 (add larger test for `proc_macro` `FromStr` implementations)
 - #148752 (Constify `ManuallyDrop::take`)
 - #148757 (Constify `mem::take`)
 - #148855 (Error if an autodiff user does not set lto=fat)
 - #148912 (add note to `lines` docs about empty str behavior)
 - #148958 (Run codegen tests on a 32-bit target in PR CI)
 - #148994 (Abi compatibility test cleanup)
 - #148999 (Tweak Motor OS linker preset, fix `remote-test-server` for Motor OS)
 - #149004 (compiletest: Avoid race condition in file deletion)
 - #149008 (triagebot: remove jsha from notifications for rustdoc HTML)
 - #149010 (compiletest: Remove the "wasm32-bare" alias for `wasm32-unknown-unknown`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6ce31bf into rust-lang:main Nov 17, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 17, 2025
rust-timer added a commit that referenced this pull request Nov 17, 2025
Rollup merge of #148999 - moturus:remote-test-server, r=jieyouxu

Tweak Motor OS linker preset, fix `remote-test-server` for Motor OS

Had to tweak linking options in target spec to make it work (see moturus/motor-os#46).
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Nov 17, 2025
Rollup of 11 pull requests

Successful merges:

 - rust-lang/rust#148505 (add larger test for `proc_macro` `FromStr` implementations)
 - rust-lang/rust#148752 (Constify `ManuallyDrop::take`)
 - rust-lang/rust#148757 (Constify `mem::take`)
 - rust-lang/rust#148855 (Error if an autodiff user does not set lto=fat)
 - rust-lang/rust#148912 (add note to `lines` docs about empty str behavior)
 - rust-lang/rust#148958 (Run codegen tests on a 32-bit target in PR CI)
 - rust-lang/rust#148994 (Abi compatibility test cleanup)
 - rust-lang/rust#148999 (Tweak Motor OS linker preset, fix `remote-test-server` for Motor OS)
 - rust-lang/rust#149004 (compiletest: Avoid race condition in file deletion)
 - rust-lang/rust#149008 (triagebot: remove jsha from notifications for rustdoc HTML)
 - rust-lang/rust#149010 (compiletest: Remove the "wasm32-bare" alias for `wasm32-unknown-unknown`)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc O-motor-os Operating system: Motor OS, https://doc.rust-lang.org/nightly/rustc/platform-support/motor.html S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants