Skip to content

Rollup of 4 pull requests #149059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 18, 2025
Merged

Rollup of 4 pull requests #149059

merged 10 commits into from
Nov 18, 2025
+108 −11

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Nov 18, 2025 •
edited by rustbot
Loading

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

RalfJung and others added 10 commits November 17, 2025 12:09
@RalfJung
flush_delayed: add note about stashed diagnostics
bad7d36
@Zalathar
Add some tests for //@ ignore-elf and //@ only-elf
d835b7c
@Zalathar
Use JSON "binary-format" to decide //@ only-elf and //@ ignore-elf
7560717
@Ayush1325
std: sys: fs: uefi: Implement stat
6106760 
- Implement std::fs::metadata function.
- Tested on qemu ovmf

Signed-off-by: Ayush Singh <ayush@beagleboard.org>
@GuillaumeGomez
Move tests/rustdoc/import_trait_associated_functions.rs into the `r…
2a1bd47 
…eexport` folder
@GuillaumeGomez
Add test for href of reexported enum variant
8642d82
@GuillaumeGomez
Rollup merge of rust-lang#148970 - Ayush1325:uefi-fs-stat, r=joboet
ff262bc 
std: sys: fs: uefi: Implement stat

- Implement std::fs::metadata function.
- Tested on qemu ovmf
@GuillaumeGomez
Rollup merge of rust-lang#149020 - RalfJung:flush_delayed, r=nnethercote
abf6d30 
flush_delayed: add note about stashed diagnostics

r? `@nnethercote`
Is `emit_stashed_diagnostics` the right advice to give? The other option seems to be to call `finish_diagnostics`. That's what I ended up doing (for now) in rust-lang/miri#4702 because it best matches what happens during normal compilation.
@GuillaumeGomez
Rollup merge of rust-lang#149026 - GuillaumeGomez:test-for-reexported…
1fd16b1 
…-variant, r=lolbinarycat

Add test for href of reexported enum variant

Working on rust-lang#148648 and realized that we actually didn't test for enum variants reexports, so here we are.

I also think I'll do rust-lang#148648 at the same time as rust-lang#148547.

r? `@lolbinarycat`
@GuillaumeGomez
Rollup merge of rust-lang#149049 - Zalathar:only-elf, r=clubby789
6120f0d 
compiletest: Use JSON "binary-format" to decide `//@ only-elf` and `//@ ignore-elf`

Some tests only apply to ELF targets, or want to enable different test revisions for ELF and non-ELF targets. So compiletest supports the `//@ only-elf` and `//@ ignore-elf` directives to make that possible.

Historically, deciding whether the current target is an ELF target relied on a handful of ad-hoc string comparisons against the target tuple.

However, nowadays compiletest has access to the output of `--print=all-target-specs-json`, and that JSON output specifies the binary format of each target, making it much easier to determine whether a target is ELF or not.
@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. rollup A PR which is a rollup labels Nov 18, 2025
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Nov 18, 2025

@bors r+ p=5 rollup=never

@bors
Copy link
Collaborator

bors commented Nov 18, 2025

📌 Commit 6120f0d has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2025
@bors
Copy link
Collaborator

bors commented Nov 18, 2025

⌛ Testing commit 6120f0d with merge 3d461af...

@bors
Copy link
Collaborator

bors commented Nov 18, 2025

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 3d461af to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 18, 2025
@bors bors merged commit 3d461af into rust-lang:main Nov 18, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 18, 2025
@rust-timer
Copy link
Collaborator

rust-timer commented Nov 18, 2025

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#148970 std: sys: fs: uefi: Implement stat f332450819b1c001366abfb5a2a0965897caca82 (link)
#149020 flush_delayed: add note about stashed diagnostics c97bfa9897b6390fc21dbf8a0f49c65dc6175f1e (link)
#149026 Add test for href of reexported enum variant 685502af0dc2f77f82162391a91291305f159e56 (link)
#149049 compiletest: Use JSON "binary-format" to decide `//@ only-e… 48a0795baea7bdcb6f2bcb512c356b20bbcc3f3c (link)

previous master: f9e7961506

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f9e7961 (parent) -> 3d461af (this PR)

Test differences

Show 7 test diffs

Stage 0

  • directives::tests::only_ignore_elf: [missing] -> pass (J2)

Stage 1

  • [rustdoc] tests/rustdoc/import_trait_associated_functions.rs: pass -> [missing] (J1)
  • [rustdoc] tests/rustdoc/reexport/enum-variant.rs: [missing] -> pass (J1)
  • [rustdoc] tests/rustdoc/reexport/import_trait_associated_functions.rs: [missing] -> pass (J1)

Stage 2

  • [rustdoc] tests/rustdoc/import_trait_associated_functions.rs: pass -> [missing] (J0)
  • [rustdoc] tests/rustdoc/reexport/enum-variant.rs: [missing] -> pass (J0)
  • [rustdoc] tests/rustdoc/reexport/import_trait_associated_functions.rs: [missing] -> pass (J0)

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 3d461af2a23456a2676aadb13b4253c87bdfe28d --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 9098.6s -> 11367.7s (+24.9%)
  2. aarch64-msvc-2: 4686.4s -> 5482.7s (+17.0%)
  3. x86_64-gnu-nopt: 6658.7s -> 7524.4s (+13.0%)
  4. x86_64-gnu-llvm-21-1: 3140.8s -> 3544.7s (+12.9%)
  5. x86_64-gnu-aux: 6344.2s -> 7081.2s (+11.6%)
  6. dist-apple-various: 3473.3s -> 3819.9s (+10.0%)
  7. x86_64-gnu-llvm-21-2: 5916.9s -> 5415.5s (-8.5%)
  8. aarch64-gnu-llvm-20-2: 2446.6s -> 2630.2s (+7.5%)
  9. dist-aarch64-msvc: 5534.3s -> 5945.7s (+7.4%)
  10. x86_64-gnu-llvm-20: 2593.6s -> 2784.6s (+7.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@GuillaumeGomez GuillaumeGomez deleted the rollup-s6m2mmy branch November 18, 2025 17:32
@rust-timer
Copy link
Collaborator

rust-timer commented Nov 18, 2025

Finished benchmarking commit (3d461af): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.9% [-2.9%, -2.9%] 1
Improvements ✅
(secondary)		 -0.4% [-0.6%, -0.1%] 4
All ❌✅ (primary) -2.9% [-2.9%, -2.9%] 1

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary -2.4%, secondary 0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.3% [3.3%, 3.3%] 1
Improvements ✅
(primary)		 -2.4% [-2.4%, -2.4%] 1
Improvements ✅
(secondary)		 -2.9% [-2.9%, -2.9%] 1
All ❌✅ (primary) -2.4% [-2.4%, -2.4%] 1

Binary size

Results (primary -1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.1% [-1.1%, -1.1%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -1.1% [-1.1%, -1.1%] 1

Bootstrap: 471.624s -> 473.417s (0.38%)
Artifact size: 388.73 MiB -> 388.75 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

7 participants

@GuillaumeGomez @bors @rust-timer @rustbot @RalfJung @Zalathar @Ayush1325