Rollup of 6 pull requests #149419
Open
Rollup of 6 pull requests #149419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is now part of the main workspace.
modules/mod_file_correct_spans.rs
modules/mod_file_disambig.rs add fix
typeck/qualified-path-params.rs merged test removed ui/qualified directory
…-timeout, r=Enselic Add a timeout to the `remote-test-client` connection Currently, the `remote-test-client` doesn't have a timeout when connecting to the `remote-test-server`. This means that running tests using it can hang indefinitely which causes issues when running tests on CI, for example. This PR now sets a default timeout of 5 minutes, meaning that if, for example, `TEST_DEVICE_ADDR=<IP:PORT> ./x test --target riscv64gc-unknown-linux-gnu tests/ui` is run and the `remote-test-server` is not reachable by the client, the client will panic after the timeout is reached. Additionally, the `TEST_DEVICE_CONNECT_TIMEOUT` env variable can be used to set up the timeout to any value (in seconds). This PR also wires up a test step for `remote-test-client`, which didn't previously have tool tests run in CI. Edit: ~~blocked by rust-lang#149071~~
Fix ICE when include_str! reads binary files ICE occurred when an invalid UTF8 file with an absolute path were included. resolve: rust-lang#149304
…gn-struct-fields, r=Kivooeo add regression test for issue rust-lang#143987 closes rust-lang#143987
Tidying up UI tests [5/N] > [!NOTE] > Intermediate commits are intended to help review, but will be squashed prior to merge. part of rust-lang#133895 merge directory * `macro_backtrace` -> `macros` * `missing_non_modrs_mod` -> `modules` * `modules_and_files_visibility` -> `modules` * `qualified` -> `typeck` * `while` -> `for-loop-whlie` r? Kivooeo
…ted-closure-ice, r=JonathanBrouwer add test for issue 143821 closes rust-lang#143821
Remove test-float-parse from workspace list in tidy It is now part of the main workspace.
rustbot
added
A-rustc-dev-guide
Member
Author
|
@bors r+ rollup=never p=5 |
Collaborator
bors
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
remote-test-clientconnection #147952 (Add a timeout to theremote-test-clientconnection)passes_align_on_fields: #143987)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup